-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor "PDB distributions" section of README #1271
base: main
Are you sure you want to change the base?
Conversation
I originally wrote this change as part of #1270, but separated it into its own PR since this one is a bit more nuanced and contains some opinions instead of just facts. More specifically, the only downside I see for advocating for embedded pdbs over separate files included in the main package is it's easier to strip separate files for people that really care about size. I'm not convinced that requiring every consumer to opt-in via |
@tmat, would you mind taking a look at this when you have a second? If you have any questions or concerns, please let me know. Thanks! |
/cc @tmat, mind making another review? If you have any questions / concerns, please let me know. Thanks! |
Since Windows-only PDBs are legacy for managed code, and this section is about managed code, the "supports all types" row isn't really relvant. Remove it.
Refactor the "PDB distributions" section of the README so that:
CopyDebugSymbolFilesFromPackages
Fixes #255