Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullability in WindowsFormsDesignerOptionService #13059

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable nullability in WindowsFormsDesignerOptionService #13059

wants to merge 1 commit into from

Conversation

gpetrou
Copy link
Contributor

@gpetrou gpetrou commented Mar 3, 2025 •
edited by dotnet-policy-service bot
Loading

Proposed changes

  • Enable nullability in WindowsFormsDesignerOptionService.
Microsoft Reviewers: Open in CodeFlow

@gpetrou gpetrou requested a review from a team as a code owner March 3, 2025 07:32
@Tanya-Solyanik
Copy link
Member

Error message
Assert.Empty() Failure: Collection was not empty\r\nCollection: [[]]

Stack trace
at System.Windows.Forms.Design.Tests.WindowsFormsDesignerOptionServiceTests.WindowsFormsDesignerOptionService_Options_GetNullDesignerOptions_ReturnsExpected() in D:\a_work\1\s\src\System.Windows.Forms.Design\tests\UnitTests\System\Windows\Forms\Design\WindowsFormsDesignerOptionServiceTests.cs:line 45
at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@Tanya-Solyanik
Copy link
Member

@gpetrou - this PR is almost ready, is it OK with you if we take it over and finish up?

@Tanya-Solyanik Tanya-Solyanik added the waiting-author-feedback The team requires more information from the author label Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gpetrou gpetrou

Labels
area: NRT waiting-author-feedback The team requires more information from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpetrou @Tanya-Solyanik