Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode fixes #13179

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

@KlausLoeffelmann
Copy link
Member Author

@RussKie: Can you give me an idea how to address the failing Labeler, here? Thanks!

@RussKie
Copy link
Member

RussKie commented Mar 24, 2025

@RussKie: Can you give me an idea how to address the failing Labeler, here? Thanks!

#13101 (comment)

@dotnet-policy-service dotnet-policy-service bot added the draft draft PR label Mar 24, 2025
@Tanya-Solyanik Tanya-Solyanik added area-DarkMode Issues relating to Dark Mode feature and removed needs-area-label labels Mar 25, 2025
@xPaw
Copy link
Contributor

xPaw commented Mar 29, 2025

I'm curious, would it be possible to target these fixes for a .NET 9 release?

@merriemcgaw
Copy link
Member

@xPaw -

I'm curious, would it be possible to target these fixes for a .NET 9 release?

Dark mode was introduced in .NET 9 as an experimental feature to gather feedback so we can make it fully supported in .NET 10. Alas, we do not service experimental features. That said, we'd love your feedback and testing of this feature for .NET 10! There are so many corner cases with Dark Mode, the more testing we get, the better!

@paul1956
Copy link
Contributor

paul1956 commented Apr 2, 2025

@merriemcgaw would love to see some sample code to address highlight colors in controls that don't support DarkMode yet. Currently StatusStrip which does not support DarkMode returns SystemColor values for ControlText and Control but don't actually use those colors to render.

So testing If DarkMode and inverting the colors the text becomes the control color and disappears.

There needs to be a way to know if a control supports DarkMode independently of "is system in DarkMode". I can work around this today but then my program would break when those controls actually support DarkMode.
When I moved to .Net 9 and enabled DarkMode some of my text just disappeared in code I hadn't changed in years.

@merriemcgaw
Copy link
Member

@KlausLoeffelmann may have some answers for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment