-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[StyleCleanUp] Correct file header/license info (IDE0073) #10372
Conversation
Yikes, I would not do this |
@robert-abeo This isn't anything new, it has been done for multiple .Net projects (See dotnet/runtime#38793 and dotnet/winforms#9615). Personally I don't see anything wrong with it, it's low risk (Can compare the IL to see there isn't any functional changes), doesn't affect git blame (It's mostly just deleted lines) and shouldn't cause conflicts for existing PRs. |
I'll just add that anyone concerned with git blame runs with |
I wouldn't keep headers. If that's the convention here so be it (its a very old one I wouldn't keep). If you are keeping the headers though I wouldn't remove this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @h3xds1nz we can take this in after resolution of the conflict.
@harshit7962 Should be alright |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10372 +/- ##
===================================================
+ Coverage 11.25210% 11.27829% +0.02618%
===================================================
Files 3353 3353
Lines 668062 668062
Branches 74980 74980
===================================================
+ Hits 75171 75346 +175
+ Misses 591642 591463 -179
- Partials 1249 1253 +4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
Thanks again for the contribution @h3xds1nz. |
@harshit7962 Thank you :) |
Fixes #10371
Description
Puts the file header into correct state, most of the time its removal of the last line, some files didn't have the header at all (ref files).
Customer Impact
Everyone is informed the project is MIT.
Regression
No.
Testing
Local build.
Risk
None, no IL changes.
Microsoft Reviewers: Open in CodeFlow