Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StyleCleanUp] Correct file header/license info (IDE0073) #10372

Merged
merged 23 commits into from
Mar 31, 2025

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Jan 30, 2025

Fixes #10371

Description

Puts the file header into correct state, most of the time its removal of the last line, some files didn't have the header at all (ref files).

Customer Impact

Everyone is informed the project is MIT.

Regression

No.

Testing

Local build.

Risk

None, no IL changes.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners January 30, 2025 22:00
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Jan 30, 2025
@robert-abeo
Copy link

Yikes, I would not do this

@ThomasGoulet73
Copy link
Contributor

ThomasGoulet73 commented Jan 31, 2025

@robert-abeo This isn't anything new, it has been done for multiple .Net projects (See dotnet/runtime#38793 and dotnet/winforms#9615). Personally I don't see anything wrong with it, it's low risk (Can compare the IL to see there isn't any functional changes), doesn't affect git blame (It's mostly just deleted lines) and shouldn't cause conflicts for existing PRs.

@h3xds1nz
Copy link
Member Author

I'll just add that anyone concerned with git blame runs with blame.ignoreRevsFile config or via param unless they're stuck in 1980.

@robert-abeo
Copy link

I wouldn't keep headers. If that's the convention here so be it (its a very old one I wouldn't keep).

If you are keeping the headers though I wouldn't remove this: // See the LICENSE file in the project root for more information.
Sometimes different components can have different licenses and the actual license file is the most important part. PLUS adding a project/license URL seems useful.

harshit7962
harshit7962 previously approved these changes Mar 31, 2025
Copy link
Member

@harshit7962 harshit7962 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @h3xds1nz we can take this in after resolution of the conflict.

@h3xds1nz
Copy link
Member Author

@harshit7962 Should be alright

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.27829%. Comparing base (2a8258a) to head (1c55deb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10372         +/-   ##
===================================================
+ Coverage   11.25210%   11.27829%   +0.02618%     
===================================================
  Files           3353        3353                 
  Lines         668062      668062                 
  Branches       74980       74980                 
===================================================
+ Hits           75171       75346        +175     
+ Misses        591642      591463        -179     
- Partials        1249        1253          +4     
Flag Coverage Δ
Debug 11.27829% <ø> (+0.02618%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@harshit7962 harshit7962 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@harshit7962 harshit7962 merged commit 4aff730 into dotnet:main Mar 31, 2025
8 checks passed
@harshit7962
Copy link
Member

Thanks again for the contribution @h3xds1nz.

@h3xds1nz
Copy link
Member Author

@harshit7962 Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE0073: Require file header
4 participants