Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NetFX-specific dead code from DWriteForwarder compilation #10641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

h3xds1nz
Copy link
Member

@h3xds1nz h3xds1nz commented Mar 25, 2025

Description

Removes utils file that's included in main but doesn't actually get compiled into the library as none of the code is used. It contains NetFX specific code anyways (including the undocumented COMPLUS_InstallRoot that can be used to swap NetFX path).

Customer Impact

Cleaner codebase for developers.

Regression

No.

Testing

Local build.

Risk

None, the code is NetFX-specific and unused.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners March 25, 2025 10:08
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.27290%. Comparing base (6514196) to head (02915e8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #10641         +/-   ##
===================================================
+ Coverage   11.22814%   11.27290%   +0.04476%     
===================================================
  Files           3352        3352                 
  Lines         668000      668027         +27     
  Branches       74980       74968         -12     
===================================================
+ Hits           75004       75306        +302     
+ Misses        591745      591466        -279     
- Partials        1251        1255          +4     
Flag Coverage Δ
Debug 11.27290% <ø> (+0.04476%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant