Add support for Okta question MFA (#151)

Co-authored-by: sevignyj <[email protected]>
dowjones · Dec 18, 2023 · dd74bde · dd74bde
1 parent dcc4b6a
commit dd74bde
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/tests/unit/test_okta.py b/tests/unit/test_okta.py
@@ -73,6 +73,7 @@ def test_bad_session_token(mocker, sample_json_response, sample_headers):
             {"_embedded": {"factor": {"factorType": "push"}}},
             345,
         ),  # Changed expected value to 2
+        ("OKTA", 321,{"_embedded": {"factor": {"factorType": "question"}}}, 321),
         ("GOOGLE", 456, {"_embedded": {"factor": {"factorType": "sms"}}}, 456),
     ],
 )

diff --git a/tokendito/okta.py b/tokendito/okta.py
@@ -1023,7 +1023,10 @@ def mfa_provider_type(
 
     elif mfa_provider == "OKTA" and factor_type == "push":
         mfa_verify = push_approval(mfa_challenge_url, payload)
-    elif mfa_provider in ["OKTA", "GOOGLE"] and factor_type in ["token:software:totp", "sms"]:
+    elif (
+        (mfa_provider in ["OKTA", "GOOGLE"] and factor_type in ["token:software:totp", "sms"])
+        or (mfa_provider == "OKTA" and factor_type == "question")
+    ):
         mfa_verify = totp_approval(
             config, selected_mfa_option, headers, mfa_challenge_url, payload, primary_auth
         )