Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace missing RawConfig #129

Merged
merged 1 commit into from
Jul 19, 2023
Merged

replace missing RawConfig #129

merged 1 commit into from
Jul 19, 2023

Conversation

sevignyj
Copy link
Contributor

@sevignyj sevignyj commented Jul 17, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sevignyj sevignyj requested a review from pcmxgti July 17, 2023 15:38
@sevignyj sevignyj marked this pull request as draft July 17, 2023 15:52
@pcmxgti
Copy link
Contributor

pcmxgti commented Jul 17, 2023

Good catch! LGTM but it seems that pytest tests are not passing.

@pcmxgti
Copy link
Contributor

pcmxgti commented Jul 18, 2023

Looks good to me. Could you:

  • Make the pytest dependency higher or equal to 7.0.0, less than or equal to 7.3.1
  • Bump the hotfix version for tokendito

Thanks

@sevignyj sevignyj force-pushed the fix/configParser branch 2 times, most recently from 77121ee to d97c5cc Compare July 18, 2023 19:53
@sevignyj sevignyj marked this pull request as ready for review July 18, 2023 20:05
@pcmxgti pcmxgti merged commit 45703a5 into main Jul 19, 2023
22 checks passed
@sevignyj sevignyj deleted the fix/configParser branch July 19, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmxgti pcmxgti pcmxgti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevignyj @pcmxgti