Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nonce to authz cookie, and minor bugfix with trailing slash #154

Merged
merged 1 commit into from
Dec 18, 2023
Merged

add nonce to authz cookie, and minor bugfix with trailing slash #154

merged 1 commit into from
Dec 18, 2023

Conversation

sevignyj
Copy link
Contributor

@sevignyj sevignyj commented Dec 18, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sevignyj sevignyj changed the title add nonce, and minor bugfix with trailing slash add nonce to authz cookie, and minor bugfix with trailing slash Dec 18, 2023
@sevignyj sevignyj marked this pull request as ready for review December 18, 2023 01:11
pcmxgti
pcmxgti reviewed Dec 18, 2023
View reviewed changes
tokendito/okta.py Outdated Show resolved Hide resolved
pcmxgti
pcmxgti reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@pcmxgti pcmxgti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but take a look at the comment on the style of get_nonce()

@sevignyj sevignyj force-pushed the fix/add_nonce branch 3 times, most recently from deacce8 to 42b6ce1 Compare December 18, 2023 17:26
pcmxgti
pcmxgti approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@pcmxgti pcmxgti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pcmxgti pcmxgti merged commit dcc4b6a into main Dec 18, 2023
23 checks passed
@pcmxgti pcmxgti deleted the fix/add_nonce branch December 18, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmxgti pcmxgti pcmxgti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sevignyj @pcmxgti