union types: fix trailing comment causing multiline when preferSingleLine is true #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
has_any_node_comment_on_different_line
doesn't currently consider the case where the final node has a trailing line comment (which is therefore on the same line).This causes issues such as the following, where we see union types randomly get multi-lined when we add a trailing comment:
Input:
add a
// todo: fix me
afterarg: '1' | '2',
Output:
Expected:
This PR fixes that by allowing a trailing line comment for the last node in the node list.
I've added tests for this case (union / intersection types), and these are the the most obvious cases I've seen so far, but it's probable that this affects many other collections as well.