Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates tests for ArgumentFuncCallToMethodCallRector #285

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

peterfox
Copy link
Collaborator

@peterfox peterfox commented Jan 7, 2025

Changes

  • updates tests for ArgumentFuncCallToMethodCallRector where the constructor is using readonly properties

Why

Without this, tests break when using the latest version of Rector.

I'm unsure why this has cropped up and what method call is the cause of this. It makes sense in the code examples to be readonly but it's odd that's just happened like this.

@peterfox peterfox added the bug Something isn't working label Jan 7, 2025
@peterfox peterfox requested a review from GeniJaho January 7, 2025 20:19
@peterfox peterfox self-assigned this Jan 7, 2025
@GeniJaho GeniJaho merged commit 478d0ed into main Jan 7, 2025
5 checks passed
@GeniJaho GeniJaho deleted the fix/failing-tests-due-to-readonly-added branch January 7, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants