Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LaravelSetProvider with missing sets #286

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

GeniJaho
Copy link
Collaborator

@GeniJaho GeniJaho commented Jan 8, 2025

Most of our rules do not appear on the Find Rule page, because they're not part of a set. And we don't have all the sets listed there.

  • Adds two missing sets: LARAVEL_COLLECTION and LARAVEL_ARRAYACCESS_TO_METHOD_CALL.
  • Replaces ARRAY_STR_FUNCTIONS_TO_STATIC_CALL with LARAVEL_ARRAY_STR_FUNCTION_TO_STATIC_CALL, since all our sets start with Laravel. We should probably deprecate the old name.
  • Reworded some of the sets, and reordered them alphabetically. The custom sets will appear first, then the Livewire 3 set, and finally the Laravel Level sets from 11 to 5.

@GeniJaho GeniJaho marked this pull request as ready for review January 9, 2025 20:24
@GeniJaho GeniJaho requested a review from peterfox January 9, 2025 20:25
@GeniJaho GeniJaho merged commit f80e95e into main Jan 14, 2025
5 checks passed
@GeniJaho GeniJaho deleted the fix-laravel-set-provider branch January 14, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants