EloquentWhereTypeHintClosureParameterRector refactor #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've fixed the downgrade rule that caused the problems rectorphp/rector-downgrade-php#263 But it would still be good to get this merged in for the additional tests etc. |
GeniJaho
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #287
Changes
Why
It looks like the
DowngradeMatchToSwitchRectorrule has an issue there which ended up removing code required to check the method causing the downgradedEloquentWhereTypeHintClosureParameterRectorto break.@driftingly @GeniJaho, we should be careful to make sure contributors add skip fixtures to cover conditions that ensure the rules they build don't affect code they're not meant to.