[MySQL] Correct $returningId() implementation to correctly store selected fields #2975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsharvey
changed the title
danielsharvey
changed the title
Currently, $returningId() only works when the primary key is in the first column (of the Drizzle table definition not the underlying MySQL table). This new test checks for this behaviour by using $returningId() when the primary key is in the second column. See drizzle-team#2971 Signed-off-by: Daniel Harvey <[email protected]>
The local variable `returning` computes the selected fields in $returningId() but throws this away. Change to correctly store config in the insert query builder. Fixed drizzle-team#2971 Signed-off-by: Daniel Harvey <[email protected]>
danielsharvey
force-pushed
the
bugfix/fix-returningid
branch
from
0018eea
to
18a460d
Compare
|
Note that for the "limit 0" and "limit -1" tests to work, I needed this fix: 218cddb (see |
AndriiSherman
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, $returningId() only works when the primary key is in the first column (of the Drizzle table definition not the underlying MySQL table).
The issues was that the local variable
returningcomputes the selected fields in the $returningId() method but throws this away. This fix updates to correctly store config in the insert query builder.Added test to cover this issue.
Fixes #2971