Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for additional chains in dex.automated_trades (part 1) #7049

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Add support for additional chains in dex.automated_trades (part 1) #7049

wants to merge 12 commits into from

Conversation

Hosuke
Copy link
Collaborator

@Hosuke Hosuke commented Oct 28, 2024 •
edited
Loading

Add more chains into dex.automated_base_trades

Including:

  1. blast
  2. base
  3. celo
  4. avalanche_c

@Hosuke Hosuke added the WIP work in progress label Oct 28, 2024
@Hosuke Hosuke marked this pull request as ready for review October 28, 2024 17:16
@Hosuke Hosuke added ready-for-review this PR development is complete, please review dbt: dex covers the DEX dbt subproject and removed WIP work in progress labels Oct 28, 2024
@Hosuke
Copy link
Collaborator Author

Hosuke commented Oct 28, 2024

Seems too many chains for a single PR, I will save some for the next PR.

@jeff-dude jeff-dude self-assigned this Oct 28, 2024
@Hosuke Hosuke changed the title Add support for additional chains in dex.automated_trades Add support for additional chains in dex.automated_trades (part 1) Oct 29, 2024
@Hosuke
Copy link
Collaborator Author

Hosuke commented Oct 29, 2024

Matching test:
https://dune.com/queries/4218565

comparison_result count projects
Match 3386503797 kyberswap, mdex, nuri, bancor, solidly_, elk_finan•••
New in new_data 39918412 radioshackrlpswap, pangolin_exchange, baguette, ya•••
Sold/Bought Mismatch 3918275 kyber, sushiswap_v2, uniswap_v2
Token Sold Address Mismatch 22675 ramses, kyber, trader_joe, sushiswap_v3_pool, unis•••
Token Bought Address Mismatch 15016 swapfish, sushiswap_v3_pool, trader_joe, ramses, u•••
Token Bought Amount Raw Mismatch 1164 uniswap_v3, pharaoh, sushiswap_v3_pool, null, soli•••

About 99% confidence in data correctness.

@Hosuke Hosuke requested a review from jeff-dude October 31, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-dude jeff-dude Awaiting requested review from jeff-dude

At least 1 approving review is required to merge this pull request.

Assignees

@jeff-dude jeff-dude

Labels
dbt: dex covers the DEX dbt subproject ready-for-review this PR development is complete, please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hosuke @jeff-dude