Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initiate eigenlayer project, models and sources #7622

Merged
merged 43 commits into from
Feb 25, 2025

Conversation

bowenli86
Copy link
Contributor

@bowenli86 bowenli86 commented Feb 4, 2025

Description:

  • initiate eigenlayer project and eigenlayer source
  • add several models, covering
    • tvl
    • inflow/outflow
    • tvd
    • avs
    • operator
    • rewards v1
    • programmatic incentive
    • strategies

quick links for more information:

@github-actions github-actions bot marked this pull request as draft February 4, 2025 23:20
Copy link

github-actions bot commented Feb 4, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added WIP work in progress dbt: daily covers the Daily dbt subproject labels Feb 4, 2025
@bowenli86 bowenli86 marked this pull request as ready for review February 4, 2025 23:20
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 4, 2025
@bowenli86
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 4, 2025
@bowenli86 bowenli86 changed the title add eigenlayer project, and v2_withdrawal_queued_flattened data model add eigenlayer project, eigenlayer source, and v2_withdrawal_queued_flattened data model Feb 4, 2025
@bowenli86
Copy link
Contributor Author

bowenli86 commented Feb 5, 2025

@jeff-dude @0xBoxer @0xRobin

@bowenli86 bowenli86 changed the title add eigenlayer project, eigenlayer source, and v2_withdrawal_queued_flattened data model initiate eigenlayer project and eigenlayer source, add v2_withdrawal_queued_flattened data model Feb 5, 2025
Copy link
Collaborator

@0xRobin 0xRobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bowenli86, thanks for starting to build on spellbook! Very exciting to have some official EigenLayer eyes on this.
We will need some more context on your vision so we can help you further.

Ideally we build the end spells as simple generic tables that are able to serve a multitude of wizards needs.

  • What end goal tables do you have in mind to expose as a spell?
  • What's your usecase for needing these tables, what are some other example usecases that wizards will be able to use the spells for?
  • What data do they currently have available (and thus what gap are we trying to fill with the spell)?

@0xRobin 0xRobin added the question Further information is requested label Feb 7, 2025
@0xRobin 0xRobin marked this pull request as draft February 7, 2025 09:30
@github-actions github-actions bot added WIP work in progress and removed ready-for-review this PR development is complete, please review labels Feb 7, 2025
@bowenli86
Copy link
Contributor Author

bowenli86 commented Feb 7, 2025

@0xRobin thank you

What end goal tables do you have in mind to expose as a spell?
What's your usecase for needing these tables, what are some other example usecases that wizards will be able to use the spells for?

none of Eigenlayer TVL boards on Dune right now are correct, b/c the calculation needs complex processing by joining multiple events, and decipher them correctly, etc

for the first phase, we will expose a few key metrics like TVL, operator<>AVS relationships, and rewards. I will decode events (bronze) and add static data to Dune, build several intermediary (silver) tables, and final gold tables for TVL, operator<>AVS relationships, and rewards

wizards can build more analysis on top of these bronze, silver and gold tables

What data do they currently have available (and thus what gap are we trying to fill with the spell)?

gaps as mentioned above. all tables i add to dune will fill the gap

eg. flattening withdrawalqueued events as a table is first step to decipher events to correct bronze tables which will contribute to futher development on top

@bowenli86 bowenli86 requested a review from 0xRobin February 7, 2025 17:41
@bowenli86 bowenli86 marked this pull request as ready for review February 8, 2025 18:50
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Feb 8, 2025
@bowenli86
Copy link
Contributor Author

@0xRobin thank you for the approval!

does the workflow also need to be approved? i can't seem to merge without it passing and it's been pending

Screenshot 2025-02-24 at 11 46 56 AM Screenshot 2025-02-24 at 11 45 22 AM

@jeff-dude
Copy link
Member

only us as maintainers can approve and run workflows. this typically only happens on first time contributor PRs. moving forward, you shouldn't hit that block. as for merging, that will also only fall on maintainers.

i will give a final review and prep for merge shortly.

@jeff-dude
Copy link
Member

thank you for the patience. i have pushed a few commits, to try to help expedite. these are mostly best practice items / reusing new utils tables for time series.

  • use _projects directory, to help keep eigenlayer models near the top and easier to find. most below that are not in this directory are legacy and we just haven't taken time to clean / organize completely
  • use blockchain in schema names, then corresponding changes to files to match. these are all ethereum, so using that chain name. this also allows flexibility in the future to add other chains without naming conflict
  • as mentioned, use new utils.days rather than rebuild yourself

@bowenli86
Copy link
Contributor Author

thank you for the patience. i have pushed a few commits, to try to help expedite. these are mostly best practice items / reusing new utils tables for time series.

  • use _projects directory, to help keep eigenlayer models near the top and easier to find. most below that are not in this directory are legacy and we just haven't taken time to clean / organize completely
  • use blockchain in schema names, then corresponding changes to files to match. these are all ethereum, so using that chain name. this also allows flexibility in the future to add other chains without naming conflict
  • as mentioned, use new utils.days rather than rebuild yourself

make sense, thanks!

@jeff-dude
Copy link
Member

okay, this all looks good to me. can you do me a favor, and query all 15 views built in CI process here on dune app, ensure you are happy with results?

@jeff-dude jeff-dude added in review Assignee is currently reviewing the PR and removed ready-for-merging labels Feb 24, 2025
@jeff-dude
Copy link
Member

also, minor note, i don't think the order by in view definitions will do anything. you can test while querying CI views if you want, but you most likely need to use the order by on the queries directly downstream

@bowenli86
Copy link
Contributor Author

@jeff-dude tried, fixed a casting issue, made a couple into tables as they seem very expensive to query repeatedly, but feel free to revert if you disagree

@jeff-dude
Copy link
Member

@jeff-dude tried, fixed a casting issue, made a couple into tables as they seem very expensive to query repeatedly, but feel free to revert if you disagree

those changes work for me. if you're good, then i'm good. keep in mind, if these tables really grow, it would be good to consider making them incremental instead. right now, they are small enough to build quickly on full history each time. let's keep this in mind as you continue to build in future PRs.

@jeff-dude jeff-dude added ready-for-merging and removed in review Assignee is currently reviewing the PR labels Feb 24, 2025
@bowenli86
Copy link
Contributor Author

@jeff-dude tried, fixed a casting issue, made a couple into tables as they seem very expensive to query repeatedly, but feel free to revert if you disagree

those changes work for me. if you're good, then i'm good. keep in mind, if these tables really grow, it would be good to consider making them incremental instead. right now, they are small enough to build quickly on full history each time. let's keep this in mind as you continue to build in future PRs.

sounds good, thank you!

@bowenli86
Copy link
Contributor Author

@jeff-dude lmk if this can be merged today

@jeff-dude jeff-dude merged commit 5305e68 into duneanalytics:main Feb 25, 2025
4 checks passed
Copy link

gitpoap-bot bot commented Feb 25, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Dune Contributor:

GitPOAP: 2025 Dune Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2025
@bowenli86 bowenli86 deleted the withdrawalq branch February 25, 2025 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: daily covers the Daily dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants