go-fuzz: set fd inheritance properly for Go 1.17+ on Windows #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During Go 1.17 development, fd inheritance on Windows was changed in:
CL 288297 - "syscall: restrict inherited handles on Windows"
https://golang.org/cl/288297
Running go-fuzz with Go 1.17 on at least some Windows versions caused errors like:
"write to testee failed: write |1: The pipe is being closed"
The fix is to properly set SysProcAttr.AdditionalInheritedHandles, which is modeled
after the suggestion from Jason Donenfeld in CL 320050:
https://go-review.googlesource.com/c/go/+/320050/-1..3#message-ed1be75fda3d32c5ff2bd037b951a875cb07c3db
Fixes dvyukov#328
josharian
approved these changes
Dec 2, 2021
This was referenced Dec 2, 2021
|
I can confirm this fixes the issue on 1.17.6 windows/amd64 |
|
Hi @dvyukov, just wanted to check in on this. Josh gave it a +1 above, and the original reporter confirmed it fixed it for them, as well as @klauspost above. Do you want to review this as well, and/or are you OK with me merging it? Just looking for a brief comment. Many balls in the air of course. 😅 |
|
I would move only the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During Go 1.17 development, fd inheritance on Windows was changed in:
CL 288297 - "syscall: restrict inherited handles on Windows"
As a result, running go-fuzz with Go 1.17 on at least some Windows versions caused errors like:
write to testee failed: write |1: The pipe is being closedThe fix is to properly set SysProcAttr.AdditionalInheritedHandles. The fix here is modeled on the suggestion from Jason Donenfeld in a later CL 320050.
Once the unit tests were updated to run against Go 1.17 but before the fix in this PR, the unit tests failed for Windows on Go 1.17 while passing on Go 1.16. With this PR, the unit tests now pass for Windows on both Go 1.16 & 1.17.
Fixes #328