Attempt at seperating round + turn machines #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gweaton
force-pushed
the
display-answer-once-round-is-over
branch
from
9010b52 to
b5fc3b2
Compare
richpjames
force-pushed
the
display-answer-once-round-is-over
branch
from
b5fc3b2 to
235df64
Compare
- split turn machine into its own file - start turn machine when starting round, then infinitely cycle until win conditions are met; set a question each time we enter the turn state and pass it down to the turn machine as input/context - we're invoking the turn machine from the round machine rather than instantiating a Turn model, like we do with the Round machine. This means we're currently not getting the same kind of logging for the turn machine as other machines - we might want to revisit this later - the turn machine currently isn't triggering the client to render the question or accept answers - the round machine doesn't currently type check - it has an action that needs moving to the turn machine - we might need to work out how to connect up with the work in `emit-timer-value-from-machine` which changes how the countdown works Co-authored-by: Rich James <[email protected]>
yndajas
force-pushed
the
display-answer-once-round-is-over
branch
from
235df64 to
f95dcf5
Compare
yndajas
reviewed
Jun 4, 2024
Comment on lines
+77
to
+80
| actions: { | ||
| type: "updateScores", | ||
| params: dynamicParamFuncs.updateScores, | ||
| }, |
There was a problem hiding this comment.
Liz suggested that we calculate the points for the turn in the turn, then pass that up to the round which can update the ongoing score tracking with the new points. Not sure if this will help us unpick some of the complexity we need to work through with updateScores or noClearWinner, but it feels like a good idea?
There was a problem hiding this comment.
Yeah, when you say it like that it makes sense
This allows us to inspect the events received by the state machine including those of child state machines, too.
Rather than invoke the turn machine directly in the round machine we now use the round model class as an intermediary to initiate the round machine. Next one the round is in the 'finished' state we will need to pass the received answers back from the turn to the round machine.
richpjames
force-pushed
the
display-answer-once-round-is-over
branch
from
dcf7332 to
18d9d96
Compare
Merged
|
Replaced by #180 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.