add lobby machine #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richpjames
force-pushed
the
lobby-machine
branch
3 times, most recently
from
86303f2 to
df27551
Compare
richpjames
force-pushed
the
lobby-machine
branch
from
df27551 to
21c7053
Compare
richpjames
force-pushed
the
lobby-machine
branch
from
21c7053 to
d6a2336
Compare
Gweaton
reviewed
Nov 22, 2023
richpjames
force-pushed
the
lobby-machine
branch
from
d6a2336 to
142b524
Compare
lookupdaily
force-pushed
the
lobby-machine
branch
from
0d7d017 to
d2e837e
Compare
richpjames
force-pushed
the
lobby-machine
branch
2 times, most recently
from
1feb860 to
0c64ca7
Compare
yndajas
reviewed
Nov 29, 2023
docs/decisions/0002-use-game-class-to-interact-with-state-machine.md
Outdated
Show resolved
Hide resolved
docs/decisions/0002-use-game-class-to-interact-with-state-machine.md
Outdated
Show resolved
Hide resolved
richpjames
force-pushed
the
lobby-machine
branch
from
1e00236 to
bd01c85
Compare
lookupdaily
force-pushed
the
lobby-machine
branch
4 times, most recently
from
6f86fa1 to
9f05665
Compare
It is useful to seperate logs that we want to keep in the application with 'debugging' logs we put in temporarily.
Previously we only had Playwright tests but we will soon have unit tests too so we need to update the script/test file and package.json
We also add lobby.typgen.ts which is imported via the 'tsTypes' key in the 'createMachine' call on line 43. This is autogenerated by the VSCode XState extension and, despite guidance in the XState docs, should be committed in order for CI to pass.
I think we should use this class as the intermediary between the state machine and the rest of the application.
- If a player leaves ensure the correct action takes place - Change the state back to OnePlayer if the player count ever reaches 1 Add tests for changing state on player leaves If we remove the cap on two players, we should add an additional test for the condition (which checks that there is only one player left before changing back to `OnePlayer` state. We should also add tests for the number of players on action 'playerLeaves'.
We were previously switching to GameStart when two players had joined the game. Instead we are displaying a button on two players joining to make 'playerClicksStart' a user triggered event to transition to 'GameStart' Add a new test that more than 2 players can join, and that 'GameStart' state only exits if one player is left.
Test that playerLeaves action removes players from the context in each state
We only want to switch to OnePlayer state if there is one player left - same as in GameStart state
richpjames
force-pushed
the
lobby-machine
branch
from
9f05665 to
6863941
Compare
yndajas
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at introducing an XState state machine to control the lobby behaviour as a proof of concept to see what using XState might look like if used across the whole app.
I have opted to use XState 4.x.x as it is better documented and I have more experience with it