enable env vars into containers #1475
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fixes in_docker problem
|
For testing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
enable defaults overwrite and into container
add .env which hold global default vars inside and outside container (helps with debugging too)
What is the current behavior? (You can also link to an open issue here)
profile>defaults>environment
What is the new behavior (if this is a feature change)? If possible add a screenshot.
profile>environment>defaults
Setting env vars writes them into ./config/.env
and gets used through docker-compose directly
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information:
⚠️ Although unlikely, this change could lead to race-conditions when 2 runs start simultaneously with different settings