Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): moved to vitest #2253

Merged
merged 4 commits into from
Sep 11, 2024
Merged

feat(tests): moved to vitest #2253

merged 4 commits into from
Sep 11, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Sep 9, 2024

Swapped all tests to use vitest.

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 99be2ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

changeset-bot bot commented Sep 9, 2024

⚠️ No Changeset found

Latest commit: 26db432

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@agliga
Copy link
Contributor Author

agliga commented Sep 9, 2024

Ready for review, tests are passing in CI (and only takes 3 mins!)

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@agliga agliga merged commit b8110ef into 14.3.0 Sep 11, 2024
4 checks passed
@agliga agliga deleted the vitest branch September 11, 2024 22:26
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants