Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(listbox/textbox): updated marko-jsons #2266

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(listbox/textbox): updated marko-jsons #2266

merged 1 commit into from
Sep 20, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Sep 18, 2024

Description

Updated marko-jsons with missing attributes

References

#2260

@agliga agliga self-assigned this Sep 18, 2024
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: 8c68012

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga marked this pull request as ready for review September 18, 2024 18:10
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are good so we should merge, but looks like some unrelated test had a failure? I don't see how your changes could have caused a Highcharts test to fail.

@agliga agliga merged commit 53442d4 into 14.3.0 Sep 20, 2024
4 checks passed
@agliga agliga deleted the marko-json branch September 20, 2024 02:19
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants