Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor download_file #1443

Merged
merged 1 commit into from
Mar 9, 2025
Merged

Refactor download_file #1443

merged 1 commit into from
Mar 9, 2025

Conversation

gutzbenj
Copy link
Member

@gutzbenj gutzbenj commented Mar 9, 2025

No description provided.

@gutzbenj gutzbenj force-pushed the gutzbenj/download branch 3 times, most recently from a497da7 to 512699f Compare March 9, 2025 20:02
@gutzbenj gutzbenj force-pushed the gutzbenj/download branch from 512699f to db1588f Compare March 9, 2025 20:37
Copy link

codecov bot commented Mar 9, 2025

Codecov Report

Attention: Patch coverage is 83.95062% with 13 lines in your changes missing coverage. Please review.

Project coverage is 82.59%. Comparing base (df044ab) to head (db1588f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
wetterdienst/provider/imgw/meteorology/api.py 44.44% 4 Missing and 1 partial ⚠️
wetterdienst/provider/imgw/hydrology/api.py 57.14% 3 Missing ⚠️
wetterdienst/provider/eumetnet/opera/sites.py 33.33% 2 Missing ⚠️
wetterdienst/util/network.py 89.47% 1 Missing and 1 partial ⚠️
wetterdienst/provider/eccc/observation/api.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1443      +/-   ##
==========================================
- Coverage   82.83%   82.59%   -0.25%     
==========================================
  Files          88       88              
  Lines        6293     6268      -25     
  Branches      737      738       +1     
==========================================
- Hits         5213     5177      -36     
- Misses        871      881      +10     
- Partials      209      210       +1     
Flag Coverage Δ
unittests 82.59% <83.95%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gutzbenj gutzbenj merged commit 294aa66 into main Mar 9, 2025
18 of 19 checks passed
@gutzbenj gutzbenj deleted the gutzbenj/download branch March 9, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant