Skip to content

Commit

Permalink
pythongh-89640: Restore configure error message on failure to detect …
Browse files Browse the repository at this point in the history
…float word order (python#126569)

Before python#126387, if we didn't detect float word order we'd raise the following
configure error:

    Unknown float word ordering. You need to manually preset
    ax_cv_c_float_words_bigendian=no (or yes) according to your system.

This puts it back (except for ARM or WASM, which as hardcoded).
  • Loading branch information
hoodmane authored and ebonnal committed Jan 10, 2025
1 parent 557ace5 commit fcde1ee
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion configure

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -5920,7 +5920,12 @@ AX_C_FLOAT_WORDS_BIGENDIAN(
stored in ARM mixed-endian order (byte order 45670123)])],
[wasm*], [AC_DEFINE([DOUBLE_IS_LITTLE_ENDIAN_IEEE754], [1],
[Define if C doubles are 64-bit IEEE 754 binary format,
stored with the least significant byte first])])])
stored with the least significant byte first])],
[AC_MSG_ERROR([m4_normalize([
Unknown float word ordering. You need to manually
preset ax_cv_c_float_words_bigendian=no (or yes)
according to your system.
])])])])

# The short float repr introduced in Python 3.1 requires the
# correctly-rounded string <-> double conversion functions from
Expand Down

0 comments on commit fcde1ee

Please sign in to comment.