Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all positive cases for Open Liberty in nightly build #305

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Add all positive cases for Open Liberty in nightly build #305

merged 7 commits into from
Jul 2, 2024

Conversation

mohamed-elzeni
Copy link
Contributor

No description provided.

@eclipse-starter-bot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@m-reza-rahman m-reza-rahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address all review comments.

@m-reza-rahman m-reza-rahman marked this pull request as draft June 24, 2024 18:29
@mohamed-elzeni mohamed-elzeni marked this pull request as ready for review June 25, 2024 09:27
@mohamed-elzeni mohamed-elzeni marked this pull request as draft June 25, 2024 15:49
@m-reza-rahman
Copy link
Contributor

I take it this is not ready for review again yet?

@mohamed-elzeni
Copy link
Contributor Author

Not yet, it needs still needs more work.

@m-reza-rahman
Copy link
Contributor

OK. Please take it out of draft mode when you think it is ready to merge or ask me explicitly to do an intermediate review of the draft.

@mohamed-elzeni mohamed-elzeni marked this pull request as ready for review June 27, 2024 13:26
@mohamed-elzeni
Copy link
Contributor Author

I have added descriptions for Docker support and restored unnecessarily deleted cases. Can you please review?

Copy link
Contributor

@m-reza-rahman m-reza-rahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please order by SE version (starting with the lowest), runtime/none (alphabetic, starting with none), EE version (starting with the lowest), profile (full, web, core), and Docker (no, yes).

So like this:

  • Run Archetype for EE 8 Web Profile, SE 8, Payara
  • Run Archetype for EE 8 Web Profile, SE 8, Payara, with Docker

Please order your part and the file overall - including existing cases. Confusing to read and evaluate otherwise for me.

@m-reza-rahman m-reza-rahman marked this pull request as draft June 27, 2024 23:43
@mohamed-elzeni
Copy link
Contributor Author

The existing cases using full profile omit full profile from the name. Should I follow this convention?

@m-reza-rahman
Copy link
Contributor

Up to you. Either way is fine as long as it is consistent across the board.

@mohamed-elzeni mohamed-elzeni marked this pull request as ready for review July 1, 2024 12:58
Copy link
Contributor

@m-reza-rahman m-reza-rahman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts with latest commits to master.

@m-reza-rahman m-reza-rahman marked this pull request as draft July 1, 2024 21:19
@mohamed-elzeni mohamed-elzeni marked this pull request as ready for review July 1, 2024 22:00
@mohamed-elzeni
Copy link
Contributor Author

All conflicts have been resolved. I believe this is ready for review now.

@m-reza-rahman
Copy link
Contributor

Well done! Merging.

@m-reza-rahman m-reza-rahman merged commit a0d5ed6 into eclipse-ee4j:master Jul 2, 2024
1 check passed
@mohamed-elzeni mohamed-elzeni deleted the nightly-open-liberty-pos-cases branch July 10, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants