-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all positive cases for Open Liberty in nightly build #305
Add all positive cases for Open Liberty in nightly build #305
Conversation
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address all review comments.
I take it this is not ready for review again yet? |
Not yet, it needs still needs more work. |
OK. Please take it out of draft mode when you think it is ready to merge or ask me explicitly to do an intermediate review of the draft. |
I have added descriptions for Docker support and restored unnecessarily deleted cases. Can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please order by SE version (starting with the lowest), runtime/none (alphabetic, starting with none), EE version (starting with the lowest), profile (full, web, core), and Docker (no, yes).
So like this:
- Run Archetype for EE 8 Web Profile, SE 8, Payara
- Run Archetype for EE 8 Web Profile, SE 8, Payara, with Docker
Please order your part and the file overall - including existing cases. Confusing to read and evaluate otherwise for me.
The existing cases using full profile omit full profile from the name. Should I follow this convention? |
Up to you. Either way is fine as long as it is consistent across the board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts with latest commits to master.
All conflicts have been resolved. I believe this is ready for review now. |
Well done! Merging. |
No description provided.