Deferring DNS resolution until connection attempt #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage if all addresses are null Signed-off-by: Chris Cameron <[email protected]>
|
Why can't I create a pull request on my fork from your fix? Your pull does not show on the list to me. |
|
Is it possible I have confused things by force-pushing a new commit since the original? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my use case I am instantiating an MQTT client at a time where I may not be able to connect to the internet yet. This is causing me problems because MqttNetworkChannel attempts to resolve the configured hostname to an IP address during construction.
By deferring the domain resolution to connection time I am able to keep queuing messages with a disconnected client on one thread, while making connection attempts on another thread, without needing to new up an MQTT client on each attempt, dropping my message queue.
I also see someone else is running into the same problem here: #119