Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed returntype of the Connect() function from byte to the complete Connack Message - Only way to determine the existence of the persistent session #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed returntype of the Connect() function from byte to the complete Connack Message - Only way to determine the existence of the persistent session #137

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b444a2
Changed returntype from byte to the complete Connack Message
Daniel900 Jul 11, 2022
feaa7dd
Descriptions of the returning message changed
Daniel900 Jul 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions M2Mqtt/MqttClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,8 @@ private void Init(string brokerHostName, int brokerPort, bool secure, X509Certif
/// Connect to broker
/// </summary>
/// <param name="clientId">Client identifier</param>
/// <returns>Return code of CONNACK message from broker</returns>
public byte Connect(string clientId)
/// <returns>CONNACK message from broker</returns>
public MqttMsgConnack Connect(string clientId)
{
return this.Connect(clientId, null, null, false, MqttMsgConnect.QOS_LEVEL_AT_MOST_ONCE, false, null, null, true, MqttMsgConnect.KEEP_ALIVE_PERIOD_DEFAULT);
}
Expand All @@ -486,8 +486,8 @@ public byte Connect(string clientId)
/// </summary>
/// <param name="clientId">Client identifier</param>
/// <param name="cleanSession">Clean sessione flag</param>
/// <returns>Return code of CONNACK message from broker</returns>
public byte Connect(string clientId,
/// <returns>CONNACK message from broker</returns>
public MqttMsgConnack Connect(string clientId,
bool cleanSession)
{
return this.Connect(clientId, null, null, false, MqttMsgConnect.QOS_LEVEL_AT_MOST_ONCE, false, null, null, cleanSession, MqttMsgConnect.KEEP_ALIVE_PERIOD_DEFAULT);
Expand All @@ -499,8 +499,8 @@ public byte Connect(string clientId,
/// <param name="clientId">Client identifier</param>
/// <param name="username">Username</param>
/// <param name="password">Password</param>
/// <returns>Return code of CONNACK message from broker</returns>
public byte Connect(string clientId,
/// <returns>CONNACK message from broker</returns>
public MqttMsgConnack Connect(string clientId,
string username,
string password)
{
Expand All @@ -515,8 +515,8 @@ public byte Connect(string clientId,
/// <param name="password">Password</param>
/// <param name="cleanSession">Clean sessione flag</param>
/// <param name="keepAlivePeriod">Keep alive period</param>
/// <returns>Return code of CONNACK message from broker</returns>
public byte Connect(string clientId,
/// <returns>CONNACK message from broker</returns>
public MqttMsgConnack Connect(string clientId,
string username,
string password,
bool cleanSession,
Expand All @@ -538,8 +538,8 @@ public byte Connect(string clientId,
/// <param name="willMessage">Will message</param>
/// <param name="cleanSession">Clean sessione flag</param>
/// <param name="keepAlivePeriod">Keep alive period</param>
/// <returns>Return code of CONNACK message from broker</returns>
public byte Connect(string clientId,
/// <returns>CONNACK message from broker</returns>
public MqttMsgConnack Connect(string clientId,
string username,
string password,
bool willRetain,
Expand Down Expand Up @@ -611,7 +611,7 @@ public byte Connect(string clientId,

this.IsConnected = true;
}
return connack.ReturnCode;
return connack;
}

/// <summary>
Expand Down