Fix connect_srv()'s arguments to include bind_port #759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this ~3yr old bug #493
I think it worth considering reworking this function to use
*args, **kwargs
for these extra arguments, or at least callconnect()
with keyword arguments.Either one would reduce issues with future failings to manually keep the functions in sync.
But that will likely raise a more intensive workflow discussion, and my goal for this is just to get this 3yr old bug fixed so I can stop using my terrible workarounds.