Add more linter #786
Closed
Add more linter #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
suggested changes
Jan 3, 2024
|
@PierreF Note that an overarching auto-formatting PR like this will make practically every single other open PR unmergeable and nearly impossible to rebase too. Please consider merging or closing them as suitable before an auto-formatting PR (and an auto-formatting PR should only include auto-formatting). |
This was referenced Jan 3, 2024
Merged
Draft
|
@akx thank for your feedback. I've splitted the PR in multiple PRs: Closing this PR in favor of other one. |
|
@PierreF Thank you, and sorry if my comments sounded a bit harsh – I've just seen the maintenance pain of big PRs like this just steamrolled through 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add black, codespell and mypy.
mypy is only partially added, mostly to client.py.