Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/space theme: Improvements in frontend cards design and stability #96

Merged
merged 5 commits into from
Mar 12, 2025
Merged

feat/space theme: Improvements in frontend cards design and stability #96

merged 5 commits into from
Mar 12, 2025

Conversation

matbmoser
Copy link
Contributor

@matbmoser matbmoser commented Mar 7, 2025 •
edited
Loading

WHY

After the PR from @pjuaristi-ikerlan #94 I wanted to improve the vision I had for the frontend style, as a "space" theme:

image

Additionally I wanted to improve the stability from the frontend components.

Also the product visualization needed some refactoring:

image

WHAT

  • Updated the frontend cards catalog to a more stabled, style override ui from the portal components
  • Updated the product component
  • Made header more stable and added tractus-x logo
  • Updated the test data
  • Added new table for the instance.
  • Improve stability from sidebar
  • Changed styles to space theme.
  • Added view button
  • Added share and actions buttons
  • Restructured product detail view with grid

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Requires merge of #94

@matbmoser matbmoser marked this pull request as draft March 7, 2025 19:27
@matbmoser matbmoser self-assigned this Mar 7, 2025
@pjuaristi-ikerlan
Copy link
Contributor

Awesome work Mathias!

pjuaristi-ikerlan
pjuaristi-ikerlan reviewed Mar 10, 2025
View reviewed changes
Copy link
Contributor

@pjuaristi-ikerlan pjuaristi-ikerlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good improvement of the design! Thanks Mathias

@matbmoser matbmoser mentioned this pull request Mar 10, 2025
Merged
@matbmoser matbmoser reopened this Mar 10, 2025
@matbmoser
Copy link
Contributor Author

We need to first merge the #94

@matbmoser matbmoser marked this pull request as ready for review March 10, 2025 15:03
@matbmoser
Copy link
Contributor Author

thx for running the dependencies check

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2025
View reviewed changes
charts/industry-core-hub/templates/deployment-backend.yaml Outdated
- name: DATABASE_PASSWORD
valueFrom:
secretKeyRef:
name: {{ include "industry-core-hub.postgresql.secretName" . }}

Check warning

Code scanning / KICS

Readiness Probe Is Not Configured Warning

metadata.name={industry-core-hub-backend}.spec.template.spec.containers.name={industry-core-hub-backend}.readinessProbe is undefined
charts/industry-core-hub/templates/deployment-backend.yaml Outdated
- name: DATABASE_PASSWORD
valueFrom:
secretKeyRef:
name: {{ include "industry-core-hub.postgresql.secretName" . }}

Check notice

Code scanning / KICS

Image Pull Policy Of The Container Is Not Set To Always Note

metadata.name={industry-core-hub-backend}.spec.template.spec.containers.name={industry-core-hub-backend}.imagePullPolicy relies on mutable images in cache
charts/industry-core-hub/templates/deployment-backend.yaml Outdated
- name: DATABASE_PASSWORD
valueFrom:
secretKeyRef:
name: {{ include "industry-core-hub.postgresql.secretName" . }}

Check notice

Code scanning / KICS

Image Without Digest Note

metadata.name={industry-core-hub-backend}.spec.template.spec.containers.name={industry-core-hub-backend}.image does not include an image digest
charts/industry-core-hub/templates/deployment-backend.yaml Outdated
- name: DATABASE_PASSWORD
valueFrom:
secretKeyRef:
name: {{ include "industry-core-hub.postgresql.secretName" . }}

Check notice

Code scanning / KICS

Secrets As Environment Variables Note

'spec.template.spec.containers.name={industry-core-hub-backend}.env.name={DATABASE_PASSWORD}.valueFrom.secretKeyRef' is defined
charts/industry-core-hub/templates/deployment-backend.yaml Outdated
- name: DATABASE_PASSWORD
valueFrom:
secretKeyRef:
name: {{ include "industry-core-hub.postgresql.secretName" . }}

Check notice

Code scanning / KICS

Liveness Probe Is Not Defined

metadata.name={industry-core-hub-backend}.spec.containers.name={industry-core-hub-backend}.livenessProbe is undefined
charts/industry-core-hub/templates/secret-backend-postgres.yaml Outdated
apiVersion: v1
kind: Secret
metadata:
name: {{ .Values.postgresql.auth.existingSecret }}

Check notice

Code scanning / KICS

Using Kubernetes Native Secret Management

External secret storage is not in use
charts/industry-core-hub/templates/secret-backend-postgres.yaml Outdated
kind: Secret
metadata:
name: {{ .Values.postgresql.auth.existingSecret }}
namespace: {{ .Release.Namespace }}

Check notice

Code scanning / KICS

Ensure Administrative Boundaries Between Resources

namespaces in use: kics-namespace
@matbmoser
Copy link
Contributor Author

I want to rebase it to main

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@matbmoser
Copy link
Contributor Author

I have reviewed and updated the changes from @pjuaristi-ikerlan also added some more quality in the code.

@matbmoser matbmoser merged commit 5b10991 into main Mar 12, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjuaristi-ikerlan pjuaristi-ikerlan pjuaristi-ikerlan left review comments

Assignees

@matbmoser matbmoser

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matbmoser @pjuaristi-ikerlan @CDiezRodriguez