-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new non periodic last sample miss detection mechanism #1861
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1861 +/- ##
==========================================
+ Coverage 70.96% 71.72% +0.75%
==========================================
Files 360 363 +3
Lines 65228 67192 +1964
==========================================
+ Hits 46291 48191 +1900
- Misses 18937 19001 +64 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not immediately clear if heartbeat
and heartbeat_change
are mutually exclusive.
Clarified. |
As far as I see there is no way to user to read the heartbeat mode and hearbeat timeout from the
This will also allow to more directly reflect the API in zenoh-c like this: #[repr(C)]
pub enum ze_advanced_publisher_heartbeat_mode_t {
PERIODIC,
SPORADIC,
}
#[repr(C)]
pub struct ze_advanced_publisher_sample_miss_detection_options_t {
pub is_enabled: bool,
pub heartbeat_mode: ze_advanced_publisher_heartbeat_mode_t,
pub heartbeat_period_ms: u64,
} |
My primary concern is that on Rust side it's possible to add more variants of heartbeat: the |
Discussed with @OlivierHecart : as the default is |
Introduces a new mechanism to allow last sample miss detection.
The mechanism reuses AdvPubSub heartbeat message but sent with
CongestionControl::Block
instead of periodically.