Swap parameters for assertArrayEquals

Signed-off-by: Aurélien Pupier <[email protected]>
eclipse · Apr 19, 2024 · 5ff88b0 · 5ff88b0
1 parent 3cf854b
commit 5ff88b0
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/...tegration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/methods/UaMethodTest.java b/...tegration-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/methods/UaMethodTest.java
@@ -63,8 +63,8 @@ public void findMethod() throws UaException {
 
         UInteger[] expected0 = {dataItem.getMonitoredItem().getMonitoredItemId()};
         UInteger[] expected1 = {dataItem.getMonitoredItem().getClientHandle()};
-        assertArrayEquals(expected0, (UInteger[]) outputs[0].getValue());
-        assertArrayEquals(expected1, (UInteger[]) outputs[1].getValue());
+        assertArrayEquals((UInteger[]) outputs[0].getValue(), expected0);
+        assertArrayEquals((UInteger[]) outputs[1].getValue(), expected1);
     }
 
     @Test
@@ -85,8 +85,8 @@ public void callMethod() throws UaException {
 
         UInteger[] expected0 = {dataItem.getMonitoredItem().getMonitoredItemId()};
         UInteger[] expected1 = {dataItem.getMonitoredItem().getClientHandle()};
-        assertArrayEquals(expected0, (UInteger[]) outputs[0].getValue());
-        assertArrayEquals(expected1, (UInteger[]) outputs[1].getValue());
+        assertArrayEquals((UInteger[]) outputs[0].getValue(), expected0);
+        assertArrayEquals((UInteger[]) outputs[1].getValue(), expected1);
     }
 
     @Test

diff --git a/...k-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/config/OpcUaClientConfigTest.java b/...k-tests/src/test/java/org/eclipse/milo/opcua/sdk/client/config/OpcUaClientConfigTest.java
@@ -108,7 +108,7 @@ public void testCopyAndModify() {
         assertEquals(uint(2), copy.getKeepAliveFailuresAllowed());
         assertEquals(uint(10000), copy.getKeepAliveInterval());
         assertEquals(uint(15000), copy.getKeepAliveTimeout());
-        assertArrayEquals(copy.getSessionLocaleIds(), new String[]{"en", "es"});
+        assertArrayEquals(new String[]{"en", "es"}, copy.getSessionLocaleIds());
         assertEquals(3.0, copy.getSubscriptionWatchdogMultiplier());
     }
 

diff --git a/...c/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/BinaryDecoderTest.java b/...c/test/java/org/eclipse/milo/opcua/stack/core/serialization/binary/BinaryDecoderTest.java
@@ -74,7 +74,7 @@ public void testEnumArray() {
         writer.writeEnumArray(null, array);
         ApplicationType[] decoded = (ApplicationType[]) reader.readEnumArray(null, ApplicationType.class);
 
-        assertArrayEquals(decoded, array);
+        assertArrayEquals(array, decoded);
     }
 
 }
diff --git a/...-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/util/ArrayUtilTest.java b/...-stack/stack-core/src/test/java/org/eclipse/milo/opcua/stack/core/util/ArrayUtilTest.java
@@ -35,9 +35,9 @@ public void testRoundTrip(Object array) throws Exception {
         Object flattened = ArrayUtil.flatten(array);
         Object unflattened = ArrayUtil.unflatten(flattened, ArrayUtil.getDimensions(array));
         if (array instanceof Object[]) {
-        	assertArrayEquals((Object[]) unflattened, (Object[]) array);
+        	assertArrayEquals((Object[]) array, (Object[]) unflattened);
         } else if (array instanceof int[]){
-        	assertArrayEquals((int[]) unflattened, (int[]) array);
+        	assertArrayEquals((int[]) array, (int[]) unflattened);
         }
     }
 
@@ -65,7 +65,7 @@ public static Object[][] getDimensions() {
     @ParameterizedTest
     @MethodSource("getDimensions")
     public void testGetDimensions(Object array, int[] dimensions) throws Exception {
-        assertArrayEquals(ArrayUtil.getDimensions(array), dimensions);
+        assertArrayEquals(dimensions, ArrayUtil.getDimensions(array));
     }
 
     public static Object[][] getTypedArrays() {