Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tss in place of the deprecated @mui/styles #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garronej
Copy link

Hello @edgarmueller,

@mui/styles (makeStyles) is deprecated in @mui/material v5. Ref.

The recommended solution with minimal DIFF is to use tss-react instead. Ref.

Thank you for this great library.

Best

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

@sdirix
Copy link
Member

sdirix commented Apr 16, 2024

Hi @garronej,
thanks for the contribution!

The deprecation notice mentions MUI System. Shouldn't we use that instead of another third party library?

@garronej
Copy link
Author

Well, tss-react is a drop-in replacement.
Besides, I find the MUI styling system cumbersome. It requires all styles to be inline or splits the component into different styled blocks, similar to styled-components.
TSS is well-established, as evidenced by its large number of downloads.

However, I'm biased since I am the author of TSS, so naturally, I believe it to be the better option 😄

Feel free to not merge; I understand your point and will take no offence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants