Add eckit dependency #293
Draft
Add eckit dependency #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, I'm working on this. What's your timeframe? |
|
Private downstream CI failed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #293 +/- ##
========================================
Coverage 87.28% 87.28%
========================================
Files 842 842
Lines 62022 62022
Branches 11062 11062
========================================
Hits 54139 54139
Misses 7883 7883 ☔ View full report in Codecov by Sentry. |
up to you, I don't need it for myself. Just that whenever eccodes-eckit are ready, we can merge this and it becomes available in the wheels as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: requires eckit release with
feature/eckit-geoincluded