Disable JWT authentication on console requests #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the plugin would initialize itself on application load. This is fine, but
Craft::$app
may be either acraft\web\Application
or acraft\console\Application
, which are different applications with different use cases.As seen in #11, this would cause all console requests to crash as the console application resolves a console request, and there is no
craft\console\Request::headers
.This PR changes the class that the plugin initialzes on from
Craft->$app
tocraft\web\Application
, causing the plugin to not attempt to authenticate a user based on the current headers on console requests.Definition of Done
composer.json
is updatedCHANGELOG.md
documenting changes made