Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporarily remove test with windows-latest, emacs snapshot" #314

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

10sr
Copy link
Member

@10sr 10sr commented Aug 2, 2023

Reverts #313

@jcs090218
Copy link
Contributor

We should revert this since it defeats the purpose of having the experimental flag set up. 🤔 Or else we could just not test the snapshot completely?

@10sr
Copy link
Member Author

10sr commented Aug 7, 2023

Umm... I think currently the experimental flag is not so good, because for now this test always marks commits as ❌ and it hides the "actual" status of the commits.
Before merging this pr I want to find a way to avoid this, or fix the failure of windows-latest-snapshot check...

@jcs090218
Copy link
Contributor

Umm... I think currently the experimental flag is not so good, because for now this test always marks commits as ❌ and it hides the "actual" status of the commits.

The idea of the experimental flag is to make the badge green but keep the status of the job remains the same ❌.

Before merging this pr I want to find a way to avoid this, or fix the failure of windows-latest-snapshot check...

There are errors from the Emacs snapshot (windows) and not from this package.

@10sr 10sr force-pushed the revert-313-removewindows-snapshot branch from 192b6dc to 665ff97 Compare May 3, 2024 09:26
@10sr
Copy link
Member Author

10sr commented Oct 24, 2024

👌

@10sr 10sr merged commit 6b97e44 into master Oct 24, 2024
13 checks passed
@10sr 10sr deleted the revert-313-removewindows-snapshot branch October 24, 2024 17:39
@jcs090218
Copy link
Contributor

Thanks for taking care of this! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants