Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke: Add note in smoke-tests about checkout ref #15903

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ericywl
Copy link
Contributor

@ericywl ericywl commented Feb 27, 2025

Motivation

I kept trying to run smoke-tests with my changes by selecting the branch from the dropdown, only to have the smoke tests run without changes. Ultimately it is PEBKAC, but I thought it would be great to have a note there so others in the future will know.

Changes

  • Add note in smoke-tests about ref checkout
  • Remove workflow dispatch input in smoke-tests-ess and smoke-tests-es since you can use the branch dropdown instead.

How to test these changes

Run smoke test workflows with this branch.

@ericywl ericywl requested a review from a team as a code owner February 27, 2025 10:06
Copy link
Contributor

mergify bot commented Feb 27, 2025

This pull request does not have a backport label. Could you fix it @ericywl? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@ericywl ericywl added the backport-skip Skip notification from the automated backport with mergify label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant