test: Enable race detector #15932
Open
test: Enable race detector #15932
+95
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @ericywl? 🙏
|
ericywl
force-pushed
the
ci/test-race
branch
2 times, most recently
from
c533712 to
ac47e45
Compare
The previous test was relying on docappender using exactly 1 bulk indexer to fulfill the request. However, due to the low flush interval setting of 1ms, there are some occassions where docappender uses 2 instead, resulting in failing unit test. We could have simply increase the flush interval but I believe that changing it makes it more consistent in the future.
ericywl
force-pushed
the
ci/test-race
branch
from
40c948f to
a6f9618
Compare
ericywl
commented
Feb 28, 2025
Comment on lines
+493
to
+499
| monitoringtest.ExpectContainOtelMetricsFunc(t, reader, map[string]monitoringtest.AssertionFunc{ | ||
| "elasticsearch.events.count": func(t *testing.T, actual any) bool { return actual.(int64) == 5 }, | ||
| "elasticsearch.events.queued": func(t *testing.T, actual any) bool { return actual.(int64) == 5 }, | ||
| "elasticsearch.bulk_requests.available": func(t *testing.T, actual any) bool { | ||
| // Available should be less than maxRequests since some will be used | ||
| return 0 < actual.(int64) && actual.(int64) < maxRequests | ||
| }, |
There was a problem hiding this comment.
[For reviewer] See commit a6f9618 for reasoning behind change.
ericywl
added
the
backport-skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Enable race detector for tests, continuation of #13827.
How to test these changes
Run unit test, system test and CI.