Add Windows test workflow and net462 test target #7769
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
force-pushed
the
netfx-tests
branch
6 times, most recently
from
4e34f9e
to
c3eda1d
Compare
flobernd
commented
Jul 6, 2023
| <CheckEolTargetFramework>false</CheckEolTargetFramework> | ||
| </PropertyGroup> | ||
| <PropertyGroup> |
There was a problem hiding this comment.
Workaround for:
rror NU1004: The project's runtime identifiers have changed from. Project's runtime identifiers: , lock file's runtime identifiers win7-x86.The packages lock file is inconsistent with the project dependencies so restore can't be run in locked mode. Disable the RestoreLockedMode MSBuild property or pass an explicit --force-evaluate option to run restore to update the lock file.
This is a known long standing issue (see comments).
Another workaround that does not involve disabling lock files, would be this one:
NuGet/Home#9195 (comment)
| public override void OnBeforeTestsRun() => TestConfiguration.Instance.DumpConfiguration(); | ||
| public override void OnBeforeTestsRun() | ||
| { | ||
| VerifierSettings.DerivePathInfo( |
There was a problem hiding this comment.
[ModuleInitializer] is not available prior to NET5.
This snippet is moved from there.
| @@ -11,7 +11,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Bogus" Version="22.1.2" /> | |||
| <PackageReference Include="Elastic.Elasticsearch.Managed" Version="0.3.5" /> | |||
| <PackageReference Include="Elastic.Elasticsearch.Managed" Version="0.4.1" /> | |||
There was a problem hiding this comment.
See elastic/elasticsearch-net-abstractions#58 for details.
flobernd
commented
Jul 19, 2023
| @@ -1,7 +1,7 @@ | |||
| { | |||
| query: { | |||
| function_score: { | |||
| boost: 1.1, | |||
There was a problem hiding this comment.
NETFX is not fully IEEE compliant which messes with our roundtrip serialization tests. Particularily float values seem to cause problems. As a workaround I changed these tests to use values that can be represented as integers.
More details: dotnet/runtime#435 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.