Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tanium] Use host.name instead of host.hostname #13122

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Mar 14, 2025

Proposed commit message

[tanium] Use `host.name` instead of `host.hostname`

ECS defines both of these fields. The `host.hostname` field is
specifically for what is output by the `hostname` command. The
`host.name` field is broader and is the better field to use in this
case.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chrisberkhout chrisberkhout added Integration:tanium Tanium Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Mar 14, 2025
@chrisberkhout chrisberkhout self-assigned this Mar 14, 2025
@chrisberkhout chrisberkhout requested a review from a team as a code owner March 14, 2025 15:42
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkroh andrewkroh added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Mar 17, 2025
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just version change. LGTM otherwise 👍🏼

Co-authored-by: Krishna Chaitanya Reddy Burri <[email protected]>
@chrisberkhout chrisberkhout enabled auto-merge (squash) March 17, 2025 10:04
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

@chrisberkhout chrisberkhout merged commit a866b5a into elastic:main Mar 17, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package tanium - 1.16.1 containing this change is available at https://epr.elastic.co/package/tanium/1.16.1/

flexitrev pushed a commit that referenced this pull request Mar 20, 2025
ECS defines both of these fields. The `host.hostname` field is
specifically for what is output by the `hostname` command. The
`host.name` field is broader and is the better field to use in this
case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:tanium Tanium Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants