-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selectize fields in agg builder #2406
Conversation
Can you update this with more emojis? 🍂 |
This will let you pass an invalid field name in, causing the app to silently fail until a full page refresh is performed. Reproduction steps:
This should probably disable the Apply button if no valid field is selected. |
Ah, good catch. Apparently I removed the required attribute on the field 🐋 |
There's still an issue with |
@rashidkpc since you have a windows VM, can you make sure this works well in IE too? Or, we can wait til we get the new box to merge this, either way. |
@@ -26,8 +26,8 @@ | |||
"angular-elastic": "~2.3.3", | |||
"angular-mocks": "~1.2.14", | |||
"angular-route": "~1.2.14", | |||
"angular-selectize.js": "w33ble/angular-selectize.js#b0dd020c", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you submit a pull to upstream for your changes to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did. EvanOxfeld/angular-selectize.js#27
There's also an issue where a test fails on angular > 1.2.25, and a bunch fail in 1.3 - got an issue for that as well, and pull that sets the version since I was unable to fix the test. EvanOxfeld/angular-selectize.js#28
On the initial load I don't seem to be able to type into this. If I hit the arrow keys a few times it works, but on inital load the type-to-search functionality seems to be broken. |
Having explored it for a while, and submitted some issues and PRs, it's become clear that angular-selectize is a bit of a mess, and there are some fundamentally broken parts. I'm not sure the author is really interested in maintaining it and I'm not convinced the issues will be resolved. I'm also not crazy with how selectize itself works, so this solution looks like a dead end. The options currently seem to be exploring a fix for chosen on firefox (if it hasn't already been fixed) or write my own select2 directive (the angular-ui one is not useable). |
Make fields "searchable" via Selectize.
Closes #2130
(Other functionality moved to #2404)
Don't forget to run
bower install
before testing 😋angular-ui-select
withangular-selectize.js
angular-ui-select
refused to work on fields, and the API was a huge painangular-selectize.js
has a much better API, worked brilliantly and doesn't lock up FFselectize
inputs match vanilla inputsChrome:
Firefox: