Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update identity to OpenJS #1509

Merged
merged 1 commit into from
Nov 28, 2023
Merged

build: Update identity to OpenJS #1509

merged 1 commit into from
Nov 28, 2023

Conversation

felixrieseberg
Copy link
Member

This PR updates our macOS identity from me to OpenJS 🎉 I've verified locally that we can still notarize with my personal account. Once this PR is merged, I'll update our infra.

➜  arm64 git:(felixr-openjs-cert) ✗ spctl -a -vvvv -t install Electron\ Fiddle.app
Electron Fiddle.app: accepted
source=Notarized Developer ID
origin=Developer ID Application: OpenJS Foundation, Inc. (UY52UFTVTM)

@felixrieseberg felixrieseberg requested review from codebytere and a team as code owners November 28, 2023 17:20
@felixrieseberg felixrieseberg changed the title Update identity to OpenJS infra: Update identity to OpenJS Nov 28, 2023
@felixrieseberg felixrieseberg changed the title infra: Update identity to OpenJS build: Update identity to OpenJS Nov 28, 2023
@coveralls
Copy link

Coverage Status

coverage: 87.191%. remained the same
when pulling 681274c on felixr-openjs-cert
into 5622127 on main.

@felixrieseberg felixrieseberg merged commit b6d0e34 into main Nov 28, 2023
@felixrieseberg felixrieseberg deleted the felixr-openjs-cert branch November 28, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsanders11 dsanders11 dsanders11 approved these changes

@codebytere codebytere Awaiting requested review from codebytere codebytere is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixrieseberg @coveralls @dsanders11