-
Notifications
You must be signed in to change notification settings - Fork 145
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add June and July 13 API WG meeting notes (#313)
* chore: add June API WG meeting notes * Add 7-13 notes
- Loading branch information
John Kleinschmidt
authored
Jul 15, 2020
1 parent
c466fd6
commit 07b8c89
Showing
3 changed files
with
88 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
# API Working Group | ||
|
||
## Date 6/15/20 | ||
|
||
### Attendees | ||
|
||
- @nornagon | ||
- @codebytere | ||
- @MarshallOfSound | ||
- @zcbenz | ||
|
||
### Visitors | ||
|
||
|
||
|
||
### Followup | ||
* @zcbenz to update [docs: views API: child views and layout engine](https://github.com/electron/governance/pull/271) with "plan B" | ||
|
||
|
||
### Agenda | ||
|
||
1. [Flagging experimental features proposal](https://hackmd.io/xikoUxTDS7WMbQIo0ZkVeA?view) | ||
- not discussed | ||
2. [API review requested PRs](https://github.com/electron/electron/labels/api-review%2Frequested%20%F0%9F%97%B3) | ||
* [feat: support dialog accessory view option on macOS](https://github.com/electron/electron/pull/23692) | ||
* **Verdict:** needs formal spec & better overview of motivation. | ||
* are we going to support rich text? what about simpsons gifs? | ||
* [feat: Add did-become-active event on mac](https://github.com/electron/electron/pull/23872) | ||
* **Verdict:** Approved | ||
* badging on nativeImage | ||
* maybe put this as an option to setIcon? rather than a method on nativeImage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
# API Working Group | ||
|
||
## Date June 29 2020 | ||
|
||
### Attendees | ||
|
||
* @nornagon | ||
* @itsananderson | ||
* @zcbenz | ||
* @codebytere | ||
* @jkleinsc | ||
|
||
### Visitors | ||
|
||
* @deepak1556 | ||
|
||
### Followup | ||
|
||
|
||
### Agenda | ||
|
||
1. [Flagging experimental features proposal](https://hackmd.io/xikoUxTDS7WMbQIo0ZkVeA?view) | ||
* Need something available before JS runs? | ||
* Combine with [fuse](https://github.com/electron/electron/pull/24241) feature? | ||
* Is it wise to reuse Chromium's feature flag? | ||
* Could have `electron.features`? | ||
* Base feature has enable/disable by default and has override | ||
* Experimental flag is useful for upgrades | ||
* Features flag doesn't require patch | ||
* Would we want to use this for deprecations? | ||
* Not at this point, but maybe in the future | ||
* Possibly use for forward looking features (eg test new feature coming in v9 in v8) | ||
* eg. https://github.com/electron/electron/issues/24086 | ||
|
||
2. [API review requested PRs](https://github.com/electron/electron/issues?q=is%3Aopen+label%3A%22api-review%2Frequested+%F0%9F%97%B3%22+-label%3Aapi-review%2Freviewed+) | ||
* [feat: expose sessionId in debugger module](https://github.com/electron/electron/pull/24170) | ||
* Approved | ||
* [feat: add app.getApplicationInfoForProtocol API](https://github.com/electron/electron/pull/24112) | ||
* Approved |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# API Working Group | ||
|
||
## Date July 13 2020 | ||
|
||
### Attendees | ||
* @itsananderson | ||
* @zcbenz | ||
* @ckerr | ||
* @jkleinsc | ||
* @MarshallOfSound | ||
|
||
### Agenda | ||
|
||
* [feat: add visible-on-all-workspaces-changed event #24485](https://github.com/electron/electron/pull/24485) | ||
* **Motivation:** At present, there is not a way to detect when the "visibleOnAllWorkspaces" property changes from outside the app, which are possible by e.g. toggling from the macOS dock. A developer could attempt to poll for changes, but that's somewhat unwieldy when we could instead add an event to more effectively notify developers of changes to this window property. | ||
* Approved conceptually but the implementation needs improvement; @zcbenz to followup in PR | ||
* [feat: add child-process-gone event to app #24367](https://github.com/electron/electron/pull/24367) | ||
* Approved |