Skip to content

Commit

Permalink
chore: add 2020-11-16 API WG meeting notes (#377)
Browse files Browse the repository at this point in the history
  • Loading branch information
jkleinsc authored Nov 17, 2020
1 parent 008ce4d commit 3a55f1b
Showing 1 changed file with 30 additions and 0 deletions.
30 changes: 30 additions & 0 deletions wg-api/meeting-notes/2020-11-16.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
# API WG Notes 2020-11-16

## Attendees

* @jkleinsc
* @nornagon
* @zcbenz
* @codebytere
* @itsananderson
* @ckerr

## Notes

1. [PRs](https://github.com/electron/electron/pulls?q=is%3Apr+label%3A%22api-review%2Frequested+%F0%9F%97%B3%22+is%3Aopen+-label%3Aapi-review%2Freviewed+sort%3Acreated-asc)
* [feat: add powerMonitor.onBatteryPower](https://github.com/electron/electron/pull/26494)
* approved
2. Discussion - what PRs should be marked as [api-review/requested 🗳](https://github.com/electron/electron/labels/api-review%2Frequested%20%F0%9F%97%B3)?
* Jeremy - suggests review by default
* Maybe have an automated bot to let folks know there are API reviews needed?
* Ad hoc approvals have happened and we should continue to do so
* This group should help reduce the number of breaking changes by making sure APIs are well designed
* Could we measure how we are doing in API design - eg measure number of breaking changes that were due to poor API design
* Decision - review APIs by default but reduce review time
3. Meeting time
* miniak - some meetings were at 1 AM Prague time
* Maybe alternate meeting times
4. New API WG chair
* @nornagon


0 comments on commit 3a55f1b

Please sign in to comment.