-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bump engines
requirement to Node 22.12
#222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a chore, please mark as feat to ensure semantic release works
engines
requirement to Node 22engines
requirement to Node 22
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other question, but this looks good 👍 If we're ready to merge, I can remove the Node 20 CI required check 😄
@erickzhao, could you also change the commit message just to be sure? Some of these repos aren't configured to default to the PR title and we've accidentally merged in the past where it grabs the first commit message instead of the title. |
7f0fc11
to
1e024cf
Compare
BREAKING CHANGE: bumps required Node.js version to >=22.0.0
Co-authored-by: David Sanders <[email protected]>
Co-authored-by: David Sanders <[email protected]>
Co-authored-by: Erik Moura <[email protected]>
"include": [ | ||
"src/**/*" | ||
], | ||
"extends": "@tsconfig/node22/tsconfig.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking here for convenience! https://github.com/tsconfig/bases/blob/main/bases/node22.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR!
Really cool seeing all the legacy code removed
Seeing file extensions on imports for ESM is new to me a well haha
Co-authored-by: David Sanders <[email protected]>
Changes addressed
engines
requirement to Node 22engines
requirement to Node 22.12
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: ESM-only. Bumps required Node.js version to >=22.12.0.