Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: bump engines requirement to Node 22.12 #222

Merged
merged 13 commits into from
Mar 14, 2025
Merged

feat!: bump engines requirement to Node 22.12 #222

merged 13 commits into from
Mar 14, 2025

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jan 10, 2025

BREAKING CHANGE: ESM-only. Bumps required Node.js version to >=22.12.0.

@electron electron deleted a comment from notion-workspace bot Jan 10, 2025
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a chore, please mark as feat to ensure semantic release works

@erickzhao erickzhao changed the title chore!: bump engines requirement to Node 22 feat!: bump engines requirement to Node 22 Jan 10, 2025
@erickzhao erickzhao marked this pull request as ready for review January 10, 2025 21:14
@erickzhao erickzhao requested a review from a team as a code owner January 10, 2025 21:14
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other question, but this looks good 👍 If we're ready to merge, I can remove the Node 20 CI required check 😄

@dsanders11
Copy link
Member

Not a chore, please mark as feat to ensure semantic release works

@erickzhao, could you also change the commit message just to be sure? Some of these repos aren't configured to default to the PR title and we've accidentally merged in the past where it grabs the first commit message instead of the title.

"include": [
"src/**/*"
],
"extends": "@tsconfig/node22/tsconfig.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@yangannyx yangannyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR!
Really cool seeing all the legacy code removed
Seeing file extensions on imports for ESM is new to me a well haha

@erickzhao erickzhao marked this pull request as draft March 11, 2025 23:22
@erickzhao erickzhao marked this pull request as ready for review March 11, 2025 23:36
@erickzhao erickzhao dismissed stale reviews from MarshallOfSound and dsanders11 March 13, 2025 22:05

Changes addressed

@erickzhao erickzhao changed the title feat!: bump engines requirement to Node 22 feat!: bump engines requirement to Node 22.12 Mar 14, 2025
@erickzhao erickzhao merged commit d914d04 into main Mar 14, 2025
3 checks passed
@erickzhao erickzhao deleted the node-2+2 branch March 14, 2025 17:23
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants