Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove test logic from lib #171

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Conversation

erickzhao
Copy link
Member

Cleans up our testing infrastructure.

Main change:

  • Properly mock the electron module with jest.mock instead of passing a mock electron object as an undocumented parameter into the source code.

Other:

  • Add ts-jest so that we're testing using TypeScript as well.
    • Remove trivial unit tests that now simply fail type assertions.
  • Update Jest verbs to match what we use in our other repos (test -> it and toThrowError -> toThrow).
  • Clean up package.json fixtures in tests.

@erickzhao erickzhao requested a review from a team as a code owner November 29, 2024 20:11
@ckerr ckerr merged commit ace95db into main Nov 30, 2024
12 checks passed
@ckerr ckerr deleted the refactor/remove-test-logic-from-lib branch November 30, 2024 12:53
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants