-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom annotation to the map. #29223
base: develop
Are you sure you want to change the base?
Conversation
Encrypt the annotations and store in the room state. Use the pinned message as the password to encrypt and decrypt. Delete annotation in the map. Choose annotation color and description while marking.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, first of all thanks for the contribution!
According to the location sharing spec, we don't support custom annotation.We mustn't use pinned message to store this kind of data.
Also, you should read the code style guide before contributing.
Using custom events for map annotations
@florianduros I will start drafting the MSC to allow annotations inside map. Thank you for the feedback. |
Encrypt the annotations and store in the room state.
Use the pinned message as the password to encrypt and decrypt.
Delete annotation in the map.
Choose annotation color and description while marking.
Checklist
public
/exported
symbols have accurate TSDoc documentation.