Remove legacy "checkbox" settings option #29282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Half-Shot
force-pushed
the
hs/remove-legacy-setting-toggle
branch
from
d6a0a18 to
7935cfb
Compare
Half-Shot
force-pushed
the
hs/remove-legacy-setting-toggle
branch
from
7935cfb to
920f2bd
Compare
Half-Shot
force-pushed
the
hs/remove-legacy-setting-toggle
branch
from
c0fca5f to
9f90f47
Compare
Base automatically changed from
hs/identity-server-picker-modernize
to
develop
February 21, 2025 13:31
Half-Shot
force-pushed
the
hs/remove-legacy-setting-toggle
branch
from
9f90f47 to
b4c926f
Compare
t3chguy
reviewed
Feb 25, 2025
Comment on lines
-27
to
-28
| // XXX: once design replaces all toggles make this the default | ||
| useCheckbox?: boolean; |
There was a problem hiding this comment.
This seems to suggest moving everything from toggles to checkboxes, what changed?
There was a problem hiding this comment.
I get the feeling this was a choice made a quite a few design iterations ago. I'm assuming since the only bit of settings to ever use checkboxes was the author's own appearance settings. it wasn't ever expanded to the rest of the components.
If the plan is to still change over to checkboxes, we can check with design. However going one way or the other would reduce some overhead here.
There was a problem hiding this comment.
Compound specifically supports both checkboxes and toggles so we should definitely query design which we should favour for what. @element-hq/design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #29280 (will adjust base branch once merged)
Split out from #29272
This removes a chunk of legacy code which used
forceTooltipVisibleto show some help text for a setting. This was only used by the identity server picker (#29280) and the font family setting. By making the font family setting use the toggle fields instead, this allows for a large chunk of code to be removed (and uses a more standard description field below an input, rather than a tooltip).See diff
Checklist
public/exportedsymbols have accurate TSDoc documentation.