New room list: basic flat list #29368
Draft
+1,637
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
db555f8 to
f1a34bf
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
f1a34bf to
8828730
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
8828730 to
58b2a25
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
58b2a25 to
57fa7ad
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
57fa7ad to
d363243
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
d363243 to
86164ff
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
86164ff to
c01ab50
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
c01ab50 to
26e12ba
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
2606f35 to
852d08e
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
852d08e to
2662f25
Compare
- Make if/else more consistent - Add comment on findAndAddRoom()
On a timeline action, we return early if payload.room is falsy. So then why do we need to retry fetching the room? I think this can be removed but will ask others if there's some conext I'm missing.
Otherwise, the room list store will get incorrect information about spaces and thus will produce an incorrect roomlist.
Implement a way to filter by active space
- Listen for updates from the store - Provide a method to open rooms
MidhunSureshR
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
2662f25 to
abac02a
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
abac02a to
b008a30
Compare
florianduros
force-pushed
the
florianduros/new-room-list/fist-step-list
branch
from
b008a30 to
e329640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task https://github.com/element-hq/wat-internal/issues/204
Figma design
This PR introduces a new virtualised room list.
The PR doesn't include:
About accessibility. The virtualised list doesn't have the ideal a11y role:
These roles can be changed manually on some nodes managed by
react-virtualized. It will be a bit dirty and I prefer to play with it in a dedicated PR.Demo
Screen.Recording.2025-03-03.at.16.09.53.mov