Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ToggleHiddenEventVisibility & GoToHome KeyBindingActions #29374

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Change ToggleHiddenEventVisibility & GoToHome KeyBindingActions #29374

wants to merge 1 commit into from

Conversation

gy-mate
Copy link
Contributor

@gy-mate gy-mate commented Feb 27, 2025 •
edited
Loading

The current keyboard shortcuts for GoToHome and ToggleHiddenEventVisibility are:

other macOS
GoToHome Ctrl–Alt–H Ctrl–Shift–H
ToggleHiddenEventVisibility Ctrl–Shift–H Cmd–Shift–H

This removes both distinctions for macOS in order ToggleHiddenEventVisibility not to conflict with...

  1. the built-in Safari keyboard shortcut for opening the Home page (Cmd–Shift–H)
  2. the KeyBindingAction for GoToHome.

This hopefully fixes #28576.

Checklist

  • Tests written for new code (and old code if feasible). N/A
  • New or updated public/exported symbols have accurate TSDoc documentation. N/A
  • Linter and other CI checks pass (or fail only due to unrelated reasons).
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@gy-mate
Change ToggleHiddenEventVisibility & GoToHome KeyBindingActions
1fd6fdc 
The current keyboard shortcuts for GoToHome and ToggleHiddenEventVisibility are:

|                             	| other        	| macOS        	|
|-----------------------------	|--------------	|--------------	|
| GoToHome                    	| Ctrl–Alt–H   	| Ctrl–Shift–H 	|
| ToggleHiddenEventVisibility 	| Ctrl–Shift–H 	| Cmd–Shift–H  	|

This removes both distinctions for macOS in order ToggleHiddenEventVisibility not to conflict with...
1. the built-in Safari keyboard shortcut for opening the Home page (Cmd–Shift–H)
2. the KeyBindingAction for GoToHome.
@gy-mate gy-mate requested a review from a team as a code owner February 27, 2025 08:49
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Feb 27, 2025
@gy-mate
Copy link
Contributor Author

gy-mate commented Feb 27, 2025

I've tested the Netlify deployment and it works well! 🎉

@florianduros florianduros self-requested a review February 27, 2025 10:08
@dbkr dbkr added the T-Defect label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

@MidhunSureshR MidhunSureshR Awaiting requested review from MidhunSureshR MidhunSureshR is a code owner automatically assigned from element-hq/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
T-Defect Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cmd–Shift–H keyboard shortcut hijacks the Safari shortcut for Home
2 participants
@gy-mate @dbkr