-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rageshake upload experience by providing useful error information #29378
base: develop
Are you sure you want to change the base?
Conversation
src/i18n/strings/en_EN.json
Outdated
@@ -407,7 +407,14 @@ | |||
"download_logs": "Download logs", | |||
"downloading_logs": "Downloading logs", | |||
"error_empty": "Please tell us what went wrong or, better, create a GitHub issue that describes the problem.", | |||
"failed_send_logs": "Failed to send logs: ", | |||
"failed_send_logs": "Failed to send logs. Could not contact the rageshake server.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reusing the i18n key will be confusing here for other languages as the meaning has drastically changed. Also doesn't this fit within "causes"? e.g. cause=unreachable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't actually need to change this now there is sufficient coverage via failed_send_logs_causes
for errors returned by the API. For everything else, I think this error is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous string (which will be what all other languages use for the foreseeable) is a partial sentence, ending with a colon. It'll never have any text rendered after it again, it'll look broken. It still needs a new key
Fixes the Element Web side of element-hq/element-meta#2732
This makes a few changes:
Previews
For a known errorcode
For a unknown errorcode
Checklist
public
/exported
symbols have accurate TSDoc documentation.